-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add support for plotting brainunit.Quantity
instances in matplotlib
#54
Open
Routhleck
wants to merge
11
commits into
main
Choose a base branch
from
visualize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for importing the `_matplotlib_compat` module in the `brainunit` package. The module is now imported using the wildcard import syntax, allowing easier access to its contents. This change improves the usability and flexibility of the `brainunit` package.
This commit adds a new function `set_axis_unit` to the `_matplotlib_compat` module. This function allows users to set the scale of the specified axis to a target unit in matplotlib plots. It takes parameters such as the axis index, target unit, matplotlib axis object, and precision for adjusting the axis labels. The function also updates the axis label with the target unit. The commit also includes a new test case `test_set_axis_unit` in the `_matplotlib_compat_test` module to verify the functionality of the `set_axis_unit` function.
chaoming0625
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we need more unit consistency checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.